This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Update stateful component example in README.md#247
Open
lexjacobs wants to merge 1 commit intomicrosoft:masterfrom
Open
Update stateful component example in README.md#247lexjacobs wants to merge 1 commit intomicrosoft:masterfrom
lexjacobs wants to merge 1 commit intomicrosoft:masterfrom
Conversation
`this.state = { currentEnthusiasm: props.enthusiasmLevel || 1 };` doesn't fill its intended purpose when the prop is falsy, such as `0`.
|
Seconded. This fixed my issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this.state = { currentEnthusiasm: props.enthusiasmLevel || 1 };doesn't fill its intended purpose when the prop is falsy, such as0.The original form actually fails the enzyme tests defined in the next section.