-
Notifications
You must be signed in to change notification settings - Fork 83
Migrated AutoShell from .NET Framework 4.8 to .Net8 #1805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted the autoShell project from the old .NET Framework 4.8 format to the modern SDK-style project targeting .NET 8.0 for Windows. Removed the Properties/AssemblyInfo.cs file, as assembly metadata is now handled by the SDK. Updated package and assembly references to use <PackageReference> for dependencies such as AudioSwitcher, WindowsAPICodePack, and Newtonsoft.Json. Enabled Windows Forms and WPF support in the project file. Cleaned up legacy configuration and build settings.
Removed several unused references and packages, including CustomMarshalers, Microsoft.VisualBasic, System.Data.DataSetExtensions, Microsoft.CSharp, AudioSwitcher.AudioApi, and AudioSwitcher.AudioApi.CoreAudio. Updated Newtonsoft.Json package from version 13.0.3 to 13.0.4. Retained Microsoft-WindowsAPICodePack-Core and Shell packages.
…reAudio because the package providing CoreAudioDevice was removed from the project. To resolve the CS0246 error, you must either re-add the AudioSwitcher.AudioApi.CoreAudio NuGet package or refactor the code to use an alternative API for audio device control.' in file 'dotnet\autoShell\AutoShell.cs'
…ssing because the AudioSwitcher.AudioApi.CoreAudio package was removed. The code is commented with instructions to restore the package and using directive to resolve the error. Line 109: The types CoreAudioDevice and CoreAudioController are missing because the AudioSwitcher.AudioApi.CoreAudio package was removed. The code is commented with instructions to restore the package and using directive to resolve the error. Line 115: The types CoreAudioDevice and CoreAudioController are missing because the AudioSwitcher.AudioApi.CoreAudio package was removed. The code is commented with instructions to restore the package and using directive to resolve the error.' in file 'dotnet\autoShell\AutoShell.cs'
…reAudio and restore the instantiation of defaultPlaybackDevice using the available GetDefaultDevice method, as the DefaultPlaybackDevice property is not present in the latest package.' in file 'dotnet\autoShell\AutoShell.cs'
…hod. Usings should be at the top of the file. Line 105: Remove commented-out code that references the old API, as the new code below uses the correct method. Line 106: Fully qualify the type and constructor to ensure the correct type is used, as the type is not available in the current usings and must be referenced directly from the AudioSwitcher.AudioApi.CoreAudio namespace.' in file 'dotnet\autoShell\AutoShell.cs'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded using github copilot (claude sonnet 4.5)