Skip to content

fix: Resolved the tag issue#348

Merged
Prajwal-Microsoft merged 5 commits intodevfrom
psl-tag-issue
Feb 19, 2026
Merged

fix: Resolved the tag issue#348
Prajwal-Microsoft merged 5 commits intodevfrom
psl-tag-issue

Conversation

@Prekshith-Microsoft
Copy link
Contributor

@Prekshith-Microsoft Prekshith-Microsoft commented Feb 18, 2026

This pull request includes several dependency upgrades and minor workflow improvements across the codebase. The most significant changes are dependency updates for both backend and frontend, improvements to Azure resource tagging logic, and updates to GitHub Actions workflows for better reliability and compatibility.

Dependency upgrades:

This pull request updates the way resource group tags are merged in both infra/main.bicep and infra/main_custom.bicep. The change ensures that existing tags are handled safely even if they are undefined, and uses the union function to combine tags more robustly.

Tag merging improvements:

  • Updated the tags property in both resourceGroupTags resources to use the union function, which safely merges existing resource group tags (using ?? {} to handle undefined cases), a set of standard tags, and allTags. This prevents errors if resourceGroup().tags is undefined and ensures all tag sources are combined correctly. [1] [2]* Upgraded backend dependencies in requirements.txt, including semantic-kernel[azure] to 1.39.2 and azure-monitor-opentelemetry to 1.8.6, which may include important bug fixes and new features. [1] [2]

Infrastructure and workflow improvements:

  • Enhanced Azure resource tagging logic in both infra/main.bicep and infra/main_custom.bicep by using the union function to merge tags more robustly, preventing errors if tags are missing. [1] [2]
  • Updated GitHub Actions workflows to use the latest versions of actions/checkout and actions/upload-artifact for improved reliability and compatibility (v6 instead of older versions). [1] [2] [3] [4] [5]

Backend code adjustments:

  • Commented out the import and configuration for Azure Monitor OpenTelemetry in api_routes.py due to issues with OpenAI calls, with a note for further investigation. [1] [2]## Purpose
  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

This pull request updates how resource group tags are merged in the infra/main.bicep and infra/main_custom.bicep files. The changes improve tag handling by using the union function, ensuring that tags are combined more reliably and that defaults are set even if some tag sets are missing.

Tag handling improvements:

  • Replaced object spread syntax with the union function to merge resourceGroup().tags, default tags (such as TemplateName, Type, and CreatedBy), and additional tags in both infra/main.bicep and infra/main_custom.bicep. This ensures tags are always merged correctly and handles cases where resourceGroup().tags may be null. [1] [2]
    This pull request updates the way resource group tags are merged in both infra/main.bicep and infra/main_custom.bicep to use the union function. This change ensures that tags are merged more robustly, handling cases where existing tags might be null and improving maintainability.

Tag merging improvements:

  • Updated the tags property in the resourceGroupTags resource to use the union function, combining existing resource group tags (with null-safe fallback), new template tags, and allTags for more reliable and readable tag merging. (infra/main.bicep, [1]; infra/main_custom.bicep, [2]

infra/main.bicep Outdated
CreatedBy: createdBy
}
tags: union(
resourceGroup().tags ?? {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the expression evaluation to a variable outside the resource and reference it here.

CreatedBy: createdBy
}
tags: union(
resourceGroup().tags ?? {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the expression evaluation to a variable outside the resource and reference it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the code

@Prajwal-Microsoft Prajwal-Microsoft merged commit 507be23 into dev Feb 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments