Merged
Conversation
infra/main.bicep
Outdated
| CreatedBy: createdBy | ||
| } | ||
| tags: union( | ||
| resourceGroup().tags ?? {}, |
Contributor
There was a problem hiding this comment.
Please move the expression evaluation to a variable outside the resource and reference it here.
infra/main_custom.bicep
Outdated
| CreatedBy: createdBy | ||
| } | ||
| tags: union( | ||
| resourceGroup().tags ?? {}, |
Contributor
There was a problem hiding this comment.
Please move the expression evaluation to a variable outside the resource and reference it here.
Contributor
Author
There was a problem hiding this comment.
Updated the code
Prajwal-Microsoft
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several dependency upgrades and minor workflow improvements across the codebase. The most significant changes are dependency updates for both backend and frontend, improvements to Azure resource tagging logic, and updates to GitHub Actions workflows for better reliability and compatibility.
Dependency upgrades:
This pull request updates the way resource group tags are merged in both
infra/main.bicepandinfra/main_custom.bicep. The change ensures that existing tags are handled safely even if they are undefined, and uses theunionfunction to combine tags more robustly.Tag merging improvements:
tagsproperty in bothresourceGroupTagsresources to use theunionfunction, which safely merges existing resource group tags (using?? {}to handle undefined cases), a set of standard tags, andallTags. This prevents errors ifresourceGroup().tagsis undefined and ensures all tag sources are combined correctly. [1] [2]* Upgraded backend dependencies inrequirements.txt, includingsemantic-kernel[azure]to1.39.2andazure-monitor-opentelemetryto1.8.6, which may include important bug fixes and new features. [1] [2]Infrastructure and workflow improvements:
infra/main.bicepandinfra/main_custom.bicepby using theunionfunction to merge tags more robustly, preventing errors if tags are missing. [1] [2]actions/checkoutandactions/upload-artifactfor improved reliability and compatibility (v6instead of older versions). [1] [2] [3] [4] [5]Backend code adjustments:
api_routes.pydue to issues with OpenAI calls, with a note for further investigation. [1] [2]## PurposeDoes this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information
This pull request updates how resource group tags are merged in the
infra/main.bicepandinfra/main_custom.bicepfiles. The changes improve tag handling by using theunionfunction, ensuring that tags are combined more reliably and that defaults are set even if some tag sets are missing.Tag handling improvements:
unionfunction to mergeresourceGroup().tags, default tags (such asTemplateName,Type, andCreatedBy), and additionaltagsin bothinfra/main.bicepandinfra/main_custom.bicep. This ensures tags are always merged correctly and handles cases whereresourceGroup().tagsmay be null. [1] [2]This pull request updates the way resource group tags are merged in both
infra/main.bicepandinfra/main_custom.bicepto use theunionfunction. This change ensures that tags are merged more robustly, handling cases where existing tags might be null and improving maintainability.Tag merging improvements:
tagsproperty in theresourceGroupTagsresource to use theunionfunction, combining existing resource group tags (with null-safe fallback), new template tags, andallTagsfor more reliable and readable tag merging. (infra/main.bicep, [1];infra/main_custom.bicep, [2]