feat(terraform): set base_name as optional parameter #351
feat(terraform): set base_name as optional parameter #351timmyreilly wants to merge 7 commits intomicrosoft:mainfrom
Conversation
timmyreilly
changed the title
There was a problem hiding this comment.
Pull request overview
This pull request parameterizes the base_name value across four Azure AI Foundry reference architectures, converting hardcoded local values into configurable Terraform variables. This enhancement allows users to customize the naming suffix for their resources while maintaining backward compatibility through sensible defaults.
Changes:
- Added
base_namevariable to all four reference architectures (foundry_basic, foundry_basic_private, foundry_standard, foundry_standard_private) - Replaced hardcoded
base_namelocal values with variable references - Maintained backward compatibility by using previous hardcoded values as defaults
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| reference_architectures/foundry_basic/variables.tf | Added base_name variable with default value "basic" |
| reference_architectures/foundry_basic/main.tf | Updated local value to reference new variable instead of hardcoded string |
| reference_architectures/foundry_basic_private/variables.tf | Added base_name variable with default value "basic-private" |
| reference_architectures/foundry_basic_private/main.tf | Updated local value to reference new variable instead of hardcoded string |
| reference_architectures/foundry_standard/variables.tf | Added base_name variable with default value "standard" |
| reference_architectures/foundry_standard/main.tf | Updated local value to reference new variable instead of hardcoded string |
| reference_architectures/foundry_standard_private/variables.tf | Added base_name variable with default value "standard-private" |
| reference_architectures/foundry_standard_private/main.tf | Updated local value to reference new variable instead of hardcoded string |
PabloZaiden
changed the title
|
@timmyreilly, thanks for the contribution! Can you run |
| variable "base_name" { | ||
| type = string | ||
| description = "Base name used as suffix in the naming module." | ||
| default = "basic" | ||
| nullable = false | ||
| } |
There was a problem hiding this comment.
The auto-generated documentation section (between BEGIN_TF_DOCS and END_TF_DOCS) needs to be regenerated to include the new base_name variable in the Inputs table. Run terraform-docs or your documentation generation tool to update this section.
| variable "base_name" { | ||
| type = string | ||
| description = "Base name used as suffix in the naming module." | ||
| default = "basic-private" | ||
| nullable = false | ||
| } |
There was a problem hiding this comment.
The auto-generated documentation section (between BEGIN_TF_DOCS and END_TF_DOCS) needs to be regenerated to include the new base_name variable in the Inputs table. Run terraform-docs or your documentation generation tool to update this section.
| variable "base_name" { | ||
| type = string | ||
| description = "Base name used as suffix in the naming module." | ||
| default = "standard" | ||
| nullable = false | ||
| } |
There was a problem hiding this comment.
The auto-generated documentation section (between BEGIN_TF_DOCS and END_TF_DOCS) needs to be regenerated to include the new base_name variable in the Inputs table. Run terraform-docs or your documentation generation tool to update this section.
| variable "base_name" { | ||
| type = string | ||
| description = "Base name used as suffix in the naming module." | ||
| default = "standard-private" | ||
| nullable = false | ||
| } |
There was a problem hiding this comment.
The auto-generated documentation section (between BEGIN_TF_DOCS and END_TF_DOCS) needs to be regenerated to include the new base_name variable in the Inputs table. Run terraform-docs or your documentation generation tool to update this section.
cmaclaughlin
left a comment
cmaclaughlin
left a comment
There was a problem hiding this comment.
Please run task docs. This will resolve the Copilot comments re: TF docs and ensure the PR passes linting & validation.
Sorry for the delay, finally got around to this - please let me know if there's anything else I need to do. |
3 participants
📥 Pull Request
🔗 Related Issue(s)
Close #352
❓ What are you trying to address
Allow base_name to be set as a variable
✨ Description of new changes
pass base_name to be used as part of the unique suffix with a default as standard.
☑️ Checklist