Skip to content

[Subcontracting] Unused Return Values fix #6663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AleksandricMarko merged 1 commit into from
Feb 22, 2026
Merged

[Subcontracting] Unused Return Values fix #6663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/Apps/W1/Subcontracting/App/src/Process/Codeunits/SubcFactboxMgmt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,7 @@ codeunit 99001507 "Subc. Factbox Mgmt."
end;
end;

procedure ShowTransferOrdersAndReturnOrder(RecRelatedVariant: Variant; LookUpPage: Boolean; IsReturn: Boolean): Integer
procedure ShowTransferOrdersAndReturnOrder(RecRelatedVariant: Variant; LookUpPage: Boolean; IsReturn: Boolean)
var
ProdOrderComponent: Record "Prod. Order Component";
ProdOrderLine: Record "Prod. Order Line";
Expand All @@ -615,7 +615,7 @@ codeunit 99001507 "Subc. Factbox Mgmt."
NoTransferExistsTxt: Label 'No transfer order exists for this purchase order.';
begin
if not RecRelatedVariant.IsRecord() then
exit(0);
exit;

DataTypeManagement.GetRecordRef(RecRelatedVariant, RecRef);

Expand All @@ -642,7 +642,7 @@ codeunit 99001507 "Subc. Factbox Mgmt."
exit;
end;
else
exit(0)
exit;
end;

TransferLine.SetCurrentKey("Prod. Order No.", "Prod. Order Line No.", "Routing Reference No.", "Routing No.", "Operation No.");
Expand Down Expand Up @@ -671,16 +671,14 @@ codeunit 99001507 "Subc. Factbox Mgmt."
until TransferLine.Next() = 0;
end;

if LookUpPage then begin
if LookUpPage then
if TempTransferHeader.Count() > 1 then
Page.Run(Page::"Transfer Orders", TempTransferHeader)
else
if TempTransferHeader.FindSet() then
Page.Run(Page::"Transfer Order", TempTransferHeader)
else
Message(NoTransferExistsTxt);
end else
exit(TempTransferHeader.Count());
end;

procedure GetSubcontractorNo(ProdOrderRoutingLine: Record "Prod. Order Routing Line"): Code[20]
Expand Down Expand Up @@ -834,7 +832,7 @@ codeunit 99001507 "Subc. Factbox Mgmt."
exit(ProdOrderComponent.Count());
end;

procedure ShowProdOrderComponents(ProdOrderRoutingLine: Record "Prod. Order Routing Line"): Decimal
procedure ShowProdOrderComponents(ProdOrderRoutingLine: Record "Prod. Order Routing Line")
var
ProdOrderComponent: Record "Prod. Order Component";
begin
Expand Down
Loading