Skip to content

Add Microsoft OneNote and SharePoint to AI Citation icon names#823

Merged
MattB-msft merged 3 commits into
mainfrom
copilot/update-ai-citations-image-names-again
May 12, 2026
Merged

Add Microsoft OneNote and SharePoint to AI Citation icon names#823
MattB-msft merged 3 commits into
mainfrom
copilot/update-ai-citations-image-names-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 11, 2026

The ClientCitationIconName types in AIEntity.cs were missing two values from the current Teams Add Citations citation.appearance.image.name list: Microsoft OneNote and Microsoft SharePoint.

Changes

  • ClientCitationIconName.Names: added MicrosoftOneNote and MicrosoftSharePoint string constants.
  • ClientCitationIconName: added matching static readonly instances.
  • ClientCitationsIconNameEnum (obsolete, kept in sync): added MicrosoftOneNote and MicrosoftSharePoint members with corresponding [EnumMember] values.
  • Tests: extended Deserialize_AllKnownNames_DeserializeCorrectly to cover the new names.

New values are inserted after MicrosoftPowerPoint to match the order in the official documentation.

var citation = new ClientCitation(
    position: 0,
    name: "Q3 Planning Notes",
    abstractText: "...",
    text: "...",
    url: null,
    keywords: null,
    iconName: ClientCitationIconName.MicrosoftOneNote);

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • learn.microsoft.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
    • Triggering command: /usr/bin/curl curl -sL REDACTED -o /tmp/citations.html (dns block)
    • Triggering command: /usr/bin/curl curl -sLv REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update AI citations image names enum to current sources Add Microsoft OneNote and SharePoint to AI Citation icon names May 11, 2026
Copilot AI requested a review from MattB-msft May 11, 2026 16:08
@github-actions github-actions Bot added ML: Core Tags changes to core libraries ML: Tests Tags changes to tests labels May 11, 2026
@MattB-msft MattB-msft marked this pull request as ready for review May 12, 2026 21:49
Copilot AI review requested due to automatic review settings May 12, 2026 21:49
@MattB-msft MattB-msft requested review from a team, ceciliaavila and sw-joelmut as code owners May 12, 2026 21:49
@MattB-msft MattB-msft merged commit f35f17e into main May 12, 2026
9 checks passed
@MattB-msft MattB-msft deleted the copilot/update-ai-citations-image-names-again branch May 12, 2026 21:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds missing Teams “Add Citations” citation.appearance.image.name values to the model layer so clients can use Microsoft OneNote and Microsoft SharePoint citation icons consistently with other known names.

Changes:

  • Added MicrosoftOneNote and MicrosoftSharePoint to ClientCitationIconName.Names and corresponding ClientCitationIconName static instances.
  • Kept the obsolete ClientCitationsIconNameEnum in sync by adding matching enum members with [EnumMember] values.
  • Extended the deserialization test coverage to include the two new names.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/libraries/Core/Microsoft.Agents.Core/Models/AIEntity.cs Adds OneNote/SharePoint constants, static instances, and obsolete enum members for citation icon names.
src/tests/Microsoft.Agents.Model.Tests/ClientCitationIconNameTests.cs Extends known-name deserialization test list to include the new icon names.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +482 to +486
/// <summary>ClientCitationIconNamee for Microsoft OneNote.</summary>
public static readonly ClientCitationIconName MicrosoftOneNote = new(Names.MicrosoftOneNote);

/// <summary>ClientCitationIconNamee for Microsoft SharePoint.</summary>
public static readonly ClientCitationIconName MicrosoftSharePoint = new(Names.MicrosoftSharePoint);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ML: Core Tags changes to core libraries ML: Tests Tags changes to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need to update the AI Citations Image names enum to pick up current list of known image sources

4 participants