Add Microsoft OneNote and SharePoint to AI Citation icon names#823
Merged
Conversation
Agent-Logs-Url: https://github.com/microsoft/Agents-for-net/sessions/a41f5c32-c748-456b-8d60-0391880db7e8 Co-authored-by: MattB-msft <10568244+MattB-msft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update AI citations image names enum to current sources
Add Microsoft OneNote and SharePoint to AI Citation icon names
May 11, 2026
tracyboehrer
approved these changes
May 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing Teams “Add Citations” citation.appearance.image.name values to the model layer so clients can use Microsoft OneNote and Microsoft SharePoint citation icons consistently with other known names.
Changes:
- Added
MicrosoftOneNoteandMicrosoftSharePointtoClientCitationIconName.Namesand correspondingClientCitationIconNamestatic instances. - Kept the obsolete
ClientCitationsIconNameEnumin sync by adding matching enum members with[EnumMember]values. - Extended the deserialization test coverage to include the two new names.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/libraries/Core/Microsoft.Agents.Core/Models/AIEntity.cs | Adds OneNote/SharePoint constants, static instances, and obsolete enum members for citation icon names. |
| src/tests/Microsoft.Agents.Model.Tests/ClientCitationIconNameTests.cs | Extends known-name deserialization test list to include the new icon names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+482
to
+486
| /// <summary>ClientCitationIconNamee for Microsoft OneNote.</summary> | ||
| public static readonly ClientCitationIconName MicrosoftOneNote = new(Names.MicrosoftOneNote); | ||
|
|
||
| /// <summary>ClientCitationIconNamee for Microsoft SharePoint.</summary> | ||
| public static readonly ClientCitationIconName MicrosoftSharePoint = new(Names.MicrosoftSharePoint); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ClientCitationIconNametypes inAIEntity.cswere missing two values from the current Teams Add Citationscitation.appearance.image.namelist:Microsoft OneNoteandMicrosoft SharePoint.Changes
ClientCitationIconName.Names: addedMicrosoftOneNoteandMicrosoftSharePointstring constants.ClientCitationIconName: added matchingstatic readonlyinstances.ClientCitationsIconNameEnum(obsolete, kept in sync): addedMicrosoftOneNoteandMicrosoftSharePointmembers with corresponding[EnumMember]values.Deserialize_AllKnownNames_DeserializeCorrectlyto cover the new names.New values are inserted after
MicrosoftPowerPointto match the order in the official documentation.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
learn.microsoft.com/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)/usr/bin/curl curl -sL REDACTED -o /tmp/citations.html(dns block)/usr/bin/curl curl -sLv REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either: