Add NodeJS SDK support for new lifecycle event typeses#222
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds NodeJS SDK support in agents-a365-notifications for additional agent lifecycle event types by introducing new lifecycle constants and corresponding AgentApplication route-registration helpers.
Changes:
- Added new lifecycle event constants for user undeleted, identity updated, and manager updated.
- Added three new
AgentApplicationextension methods to register handlers for the new lifecycle notifications. - Expanded lifecycle event validation to recognize the newly supported event types.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| packages/agents-a365-notifications/src/constants.ts | Adds new lifecycle event string constants used for routing/validation. |
| packages/agents-a365-notifications/src/agent-notification.ts | Wires new lifecycle constants into routing helpers, validation, and AgentApplication module augmentation. |
gwharris7
requested changes
Mar 30, 2026
Contributor
gwharris7
left a comment
gwharris7
left a comment
There was a problem hiding this comment.
@eddie-lee-msft Waiting for these lifecycle event types to be sent
gwharris7
approved these changes
Apr 22, 2026
sellakumaran
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add NodeJS SDK support for new lifecycle event typeses