Skip to content

Revert: Fix GetCallerBaggagePairs userId fallback#250

Merged
fpfp100 merged 1 commit into
mainfrom
revert-userid-fallback
May 14, 2026
Merged

Revert: Fix GetCallerBaggagePairs userId fallback#250
fpfp100 merged 1 commit into
mainfrom
revert-userid-fallback

Conversation

@fpfp100
Copy link
Copy Markdown
Contributor

@fpfp100 fpfp100 commented May 13, 2026

Summary

Reverts #246.

The ingest service only accepts GUIDs for user.id. Any non-GUID value gets replaced with an all-zeros GUID (00000000-0000-0000-0000-000000000000). Allowing non-GUID values as userId (via the AadObjectId → AgenticUserId → From.Id fallback chain) breaks downstream scenarios that expect an AAD object ID.

Test plan

  • Verify existing tests pass
  • Confirm userId is only set from AadObjectId again

🤖 Generated with Claude Code

Note

The original PR will not take effect since UPN (non-GUID) values are always ignored by the ingestion service.

Copilot AI review requested due to automatic review settings May 13, 2026 21:32
@fpfp100 fpfp100 requested a review from a team as a code owner May 13, 2026 21:32
@github-actions
Copy link
Copy Markdown

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@fpfp100 fpfp100 merged commit 4520d30 into main May 14, 2026
11 checks passed
@fpfp100 fpfp100 deleted the revert-userid-fallback branch May 14, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants