Skip to content

[wip] V5#51

Open
kesla wants to merge 7 commits into
masterfrom
v5
Open

[wip] V5#51
kesla wants to merge 7 commits into
masterfrom
v5

Conversation

@kesla

@kesla kesla commented Mar 7, 2017

Copy link
Copy Markdown
Contributor
  • enforce using Errors in throws & .rejects
  • require more flow
  • consistency around how to write the flow definition
  • changelog
  • engines field in package.json

Lmk if anything of this is crazy.

@kesla kesla mentioned this pull request Mar 7, 2017
@kesla

kesla commented Mar 9, 2017

Copy link
Copy Markdown
Contributor Author

@orrybaram @danmakenoise @Roilan Updated

Comment thread package.json
"homepage": "https://github.com/micnews/miclint#readme",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
"test": "node bin.js bin.js index.js options.js"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why bin.js twice?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we check bin w bin.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first we run bin, then we check it

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can I make that more obvious somehow?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kesla sorry for delayed response, can it not support globs? node bin.js *.js?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants