Remove kroger.com from disposable email domains list #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroger.com is a legitimate corporate domain (Fortune 500 company) and should not be flagged as a disposable email service. This change allows legitimate corporate users with @kroger.com email addresses to sign up for services using this gem.
krogerco.com is another legitimate corporate domain (Kroger Company) and should not be flagged as a disposable email service. This change allows legitimate corporate users with @krogerco.com email addresses to sign up for services using this gem.
dkgrayson
changed the title
Contributor
Author
|
@phoet Would you be able to review this, please? It is impacting our clients. Thank you! |
Collaborator
|
Sorry for the delay, I was on vacation. kroger.com looks fine, while krogerco.com does not https://check-mail.org/domain/krogerco.com/ The domain krogerco.com is on sale. What brings you to the conclusion that the two are related? |
krogerco.com is not a valid corporate domain and should remain in the disposable email domains list. Only kroger.com should be removed as it is a legitimate Fortune 500 corporate domain.
dkgrayson
changed the title
Contributor
Author
|
Thank you @phoet, I think you are right and I made a bad assumption with that one if it is for sale. I'll remove and stick with just kroger.com. No worries for the delay, I hope your vacation was nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
kroger.com is currently listed in the disposable email domains list, which incorrectly flags legitimate corporate email addresses as disposable. This prevents users with @kroger.com email addresses from signing up for services that use this gem for email validation.
Solution
Remove kroger.com from the disposable email domains list since it's a legitimate corporate domain (Fortune 500 company).
Note: krogerco.com remains in the disposable domains list as it is not a valid corporate domain.