Fix HDFConverter static method inconsistency#50
Merged
michael-petersen merged 3 commits intohdf5from Dec 12, 2025
Merged
Conversation
Co-authored-by: michael-petersen <19195541+michael-petersen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP to address feedback on Draft HDF5 converter PR
Fix HDFConverter static method inconsistency
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
HDFConverter.__init__callsself.convert_psp_to_hdf5()with no arguments, but the method was decorated as@staticmethodand expected aninputfilenameparameter.Changes
convert_psp_to_hdf5,print_component_header, andmake_phasespacefrom static methods to instance methodsself.filenameinstead of taking filename as a parameterHDFConverter.convert_psp_to_hdf5(args.filename)toHDFConverter(args.filename)Before
After
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.