Skip to content

Conversation

@willnewton
Copy link

This adds a few options to get-pdfs-of-issues.py to filter what issues are handled and how much data is printed.

continue

if label:
found = False
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be reduced to:

            if not any(l['name'] == label for l in issue['labels']):
                continue

@mhl
Copy link
Owner

mhl commented May 26, 2016

Thanks very much for the pull request! This all looks useful - I left a small comment where I think the label code could be simplified.

My only other thought was that it might be nice to use the API for fetching an issue label and a milestone to check that the user's supplied a label / milestone that actually exists before iterating over all the issues. I'm happy to merge this without that, though, if you don't think that's worth changing this PR for :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants