Skip to content

Fix CodeClimate and MetricFu issues#238

Open
vitorbaraujo wants to merge 6 commits into
mezuro:masterfrom
MES2017:clean_code
Open

Fix CodeClimate and MetricFu issues#238
vitorbaraujo wants to merge 6 commits into
mezuro:masterfrom
MES2017:clean_code

Conversation

@vitorbaraujo

@vitorbaraujo vitorbaraujo commented Jun 8, 2017

Copy link
Copy Markdown
  • Refactor self.task method in Processor::Collector
  • Refactor self.task method in Processor::Interpreter
  • Apply some Ruby best practices in methods above
  • Refactor metric_result_history_of method in Repository

vitorbaraujo and others added 6 commits June 1, 2017 17:28
This method was too big, becoming very difficult to understand
This refactoring decreases the cyclomatic complexity of this method
and also makes the code more understandable
Improve complexity metrics in Processor module
Signed-off-by: Marcelo Cristiano <marceloabk@hotmail.com>
Extract code to a method to reduce complexity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants