Playlist init: Make library optional + Define Library Attachment Strategy#74
Draft
Playlist init: Make library optional + Define Library Attachment Strategy#74
library optional + Define Library Attachment Strategy#74Conversation
implementations.
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playlist constructors currently require a
libraryparameter:This feels awkward because we're forced to provide a library even when just creating playlists locally, there is no guarantee the library is actually connected or valid at that point, and the base class doesn't enforce a consistent signature (no abstract
__init__). Overall this introduces an implicit dependency on a live service too early imo.Proposal:
In migration or transformation scenarios, we often construct playlists, transform or filter them, and only then decide to persist them. Requiring a library upfront forces us to bind to a service prematurely, which doesn't match this workflow. Instead, we could allow constructing playlists without a library and attach it later when needed.
The library would then be attached explicitly via playlist.attach_library(lib) or playlist.library = lib. This allows creating playlists locally and attaching them retroactively once a concrete backend is available. This should make it easier to create multi-user and multi-library workflows. Also makes working with the library more intuitive imo.