feat: LifecycleEventTracker algorithm [2/4]#31
Open
choudlet wants to merge 2 commits into
Open
Conversation
This was referenced Apr 27, 2026
choudlet
commented
Apr 27, 2026
| storedVersion == null && storedBuild == null -> { | ||
| if (identityManager.hasAnyValue()) { | ||
| // Existing user upgrading from a pre-lifecycle SDK build. | ||
| emitUpdated(currentVersion, currentBuild, LIFECYCLE_UNKNOWN, LIFECYCLE_UNKNOWN) |
Collaborator
Author
There was a problem hiding this comment.
in an unknown state here where there is identify info stored but no previous builds and versions so just run with UNKNOWN
The lifecycle event tracker — install/update detection, cold-launch sequencing, foreground/background transitions, and the one-shot deep-link buffer. Standalone class; not yet wired into MetaRouterAnalyticsClient (slice 3 does the wiring). Cold-launch decision tree: - no persisted state, no identity → Application Installed - no persisted state, identity present → Application Updated with previous_version/previous_build = 'unknown' (SDK upgrade) - persisted (version, build) matches → no install/update event - persisted (version, build) differs → Application Updated with prior values Cold-launch Opened ordering depends on the foreground-state probe: - foreground at SDK init → emit Opened immediately and suppress the imminent ProcessLifecycleOwner.onStart so we don't double-emit - background at SDK init (silent push, JobScheduler, WorkManager) → defer Opened to the first true ON_START transition, which then emits with from_background=false as the cold-launch bridge Deep-link buffer is one-shot and last-write-wins. Multiple openURL calls before the next Opened keep only the most recent URL; the buffer clears once attached to an Opened payload. The tracker has no on/off switch — when the feature is disabled the host (LifecycleCoordinator, slice 3) simply never constructs an instance. AppContext is injected (the cached snapshot from slice 1) so the tracker never reads PackageManager itself. Refs: sc-38234
Three follow-ups from code review on slice 2. - defaultForegroundCheck: narrow the catch from Throwable to IllegalStateException + NoClassDefFoundError. The wide catch swallowed OOM / StackOverflowError silently. ProcessLifecycleOwner.get() throws ISE off the main thread; the lifecycle-process artifact may be stripped in test setups, hence NoClassDefFoundError. Anything else surfaces as a real bug. - onSdkReady: AtomicBoolean idempotency guard. If the host accidentally invokes the cold-launch sequence twice (future re-init path, test misuse) we used to re-emit Installed/Updated/Opened and stomp suppressNextForeground, which would eat the next legitimate foreground transition. - KDoc: openURL / handleDeepLink reference said EXTRA_REFERRER goes through getStringExtra. Per Android docs EXTRA_REFERRER is a Uri, not a String — getStringExtra on it is essentially always null. Point hosts at Activity.referrer?.host instead. - Tests cover the new idempotency guard and the onForeground-before- onSdkReady contract (documenting what happens if the host wiring invariant breaks). Refs: sc-38234
choudlet
force-pushed
the
chrish/sc-38234/lifecycle-event-tracker
branch
from
78e1343 to
f30267a
Compare
Collaborator
Author
|
This has the most complex logic in terms of when the SDK decides to emit certain events. Tried to be verbose with the comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shortcut: sc-38234
Parent: sc-36799
iOS reference: sc-38229
Slice 2 of 4 — standalone tracker; not yet wired in.
Summary
The lifecycle-event algorithm — install/update detection, cold-launch sequencing, foreground/background transitions, and the one-shot deep-link buffer. Lands as one self-contained class with thorough Robolectric-backed unit tests so reviewers can validate the state machine in isolation.
Cold-launch decision tree
(version, build), no identity →Application Installed(version, build), identity present →Application Updated{previous_version:"unknown", previous_build:"unknown"}(SDK upgrade)(version, build)matches → no install/update event(version, build)differs (version OR build) →Application Updatedwith prior valuesCold-launch Opened ordering
ProcessLifecycleOwner.onStartso we don't double-emitJobScheduler,WorkManager) → defer; first trueON_STARTemits withfrom_background=falseas the cold-launch bridgeDeep-link buffer
Application OpenedemitopenURL(uri, sourceApplication)is the named-after-signal API — slice 3 exposes it publiclyThe tracker has no on/off switch; when the feature is disabled the host (
LifecycleCoordinator, slice 3) simply never constructs an instance.AppContextis injected (the cached snapshot from slice 1) so the tracker never touchesPackageManager.Stack
LifecycleEventTrackeralgorithm + testsMetaRouterAnalyticsClientwiring +openURLpublic APITest plan
./gradlew :metarouter-sdk:testpassesLifecycleEventTrackerTest— full state-machine coverage (cold-launch tree, foreground deferral, deep-link one-shot/last-write-wins, two-cycle background→foreground)