Fix local IP addr lookup#17
Open
cFire wants to merge 1 commit into
Open
Conversation
In cases where the default subnet for an IPv4 private network does not match the locally configured subnet on the interface, the local IP lookup would fail. Example: local ip 10.0.0.100/24, but the default subnet for this private range is 10.0.0.0/8. It would also fail for any IPv6 lookups since no default mask is defined for private IPv6 ranges. This mehtod of checking if the target IP address lies within the subnet configured on the interface fixes both of those problems by not reying on the default subnet at all but by reading the configured subnet from the interfaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases where the default subnet for an IPv4 private network does not
match the locally configured subnet on the interface, the local IP lookup
would fail.
Example: local ip 10.0.0.100/24, but the default subnet for this private
range is 10.0.0.0/8.
It would also fail for any IPv6 lookups since no default mask is defined
for private IPv6 ranges.
This mehtod of checking if the target IP address lies within the subnet
configured on the interface fixes both of those problems by not reying
on the default subnet at all but by reading the configured subnet from
the interfaces.