Skip to content

Add Mac target to Chapter 2 project #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bgulanowski wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Mac target to Chapter 2 project #2

bgulanowski wants to merge 2 commits into from

Conversation

@bgulanowski
Copy link

@bgulanowski bgulanowski commented Jun 18, 2018 •
edited
Loading

  • Xcode 9.4 bookkeeping and changes
  • new target
  • make the MBEMetalView support Mac as well as iOS (using conditional compilation)

I choose to reuse the existing view class to achieve:

  • avoid code duplication
  • avoid factoring out a shared renderer object (done in later chapters)
  • highlight differences between Mac and iOS layer handling

-displayLayer:works, but may not be the ideal design. Docs say to override -updateLayer, but I couldn't get that to work.

Best to merge #3 first

@bgulanowski bgulanowski force-pushed the ch02-mac branch 2 times, most recently from 806d19d to 84bfbac Compare June 18, 2018 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bgulanowski