Skip to content

Updated ci.yml file and upgraded protocol version#194

Merged
viferga merged 2 commits intometacall:masterfrom
miantalha45:updated-ci-protocol-version
Mar 9, 2026
Merged

Updated ci.yml file and upgraded protocol version#194
viferga merged 2 commits intometacall:masterfrom
miantalha45:updated-ci-protocol-version

Conversation

@miantalha45
Copy link
Copy Markdown
Contributor

Summary

Updated ci.yml file for changing the procedure of publishing on npm
upgraded protocol version in package.json

Copilot AI review requested due to automatic review settings February 25, 2026 18:08
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s npm publishing workflow and bumps the @metacall/protocol dependency version, aligning CI/release behavior with the new publishing approach.

Changes:

  • Bump @metacall/protocol from ^0.1.24 to ^0.1.27 in package.json.
  • Update GitHub Actions workflow permissions and change Node version used in CI.
  • Change npm publishing approach (move away from the previous token-based npm-publish action configuration toward npm publish --provenance).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
package.json Upgrades @metacall/protocol dependency version.
.github/workflows/ci.yml Adjusts workflow permissions, Node version, and the npm publish step/procedure.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml Outdated

- name: Publish
uses: JS-DevTools/npm-publish@v1
uses: JS-DevTools/npm-publish@v2
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow step is invalid because it specifies both uses: and run: in the same step. GitHub Actions requires a step to use either an action (uses) or a shell command (run). Remove uses: JS-DevTools/npm-publish@v2 and keep the run block, or switch back to using the action with appropriate inputs (and no run).

Suggested change
uses: JS-DevTools/npm-publish@v2

Copilot uses AI. Check for mistakes.
@metacall metacall deleted a comment from Copilot AI Mar 9, 2026
@metacall metacall deleted a comment from Copilot AI Mar 9, 2026
@viferga
Copy link
Copy Markdown
Member

viferga commented Mar 9, 2026

Next PR if it has copilot messages I am going to automatically close it @miantalha45

@viferga
Copy link
Copy Markdown
Member

viferga commented Mar 9, 2026

The CI is not passing, I pointed out why multiple times in the group and other PRs.

@viferga
Copy link
Copy Markdown
Member

viferga commented Mar 9, 2026

I will solve it myself, next time I will discard it automatically.

@viferga viferga merged commit a2a8a8e into metacall:master Mar 9, 2026
1 check failed
@miantalha45
Copy link
Copy Markdown
Contributor Author

Ok @viferga
Next time i will keep your instructions in mind.
Thank you for merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants