Updated ci.yml file and upgraded protocol version#194
Updated ci.yml file and upgraded protocol version#194viferga merged 2 commits intometacall:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project’s npm publishing workflow and bumps the @metacall/protocol dependency version, aligning CI/release behavior with the new publishing approach.
Changes:
- Bump
@metacall/protocolfrom^0.1.24to^0.1.27inpackage.json. - Update GitHub Actions workflow permissions and change Node version used in CI.
- Change npm publishing approach (move away from the previous token-based
npm-publishaction configuration towardnpm publish --provenance).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Upgrades @metacall/protocol dependency version. |
| .github/workflows/ci.yml | Adjusts workflow permissions, Node version, and the npm publish step/procedure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Publish | ||
| uses: JS-DevTools/npm-publish@v1 | ||
| uses: JS-DevTools/npm-publish@v2 |
There was a problem hiding this comment.
This workflow step is invalid because it specifies both uses: and run: in the same step. GitHub Actions requires a step to use either an action (uses) or a shell command (run). Remove uses: JS-DevTools/npm-publish@v2 and keep the run block, or switch back to using the action with appropriate inputs (and no run).
| uses: JS-DevTools/npm-publish@v2 |
|
Next PR if it has copilot messages I am going to automatically close it @miantalha45 |
|
The CI is not passing, I pointed out why multiple times in the group and other PRs. |
|
I will solve it myself, next time I will discard it automatically. |
|
Ok @viferga |
Summary
Updated ci.yml file for changing the procedure of publishing on npm
upgraded protocol version in package.json