Skip to content

range-v3: add option to disable tests#2625

Open
bryceberger wants to merge 6 commits intomesonbuild:masterfrom
bryceberger:range-v3/disable-tests
Open

range-v3: add option to disable tests#2625
bryceberger wants to merge 6 commits intomesonbuild:masterfrom
bryceberger:range-v3/disable-tests

Conversation

@bryceberger
Copy link

Previously #1535, not given an explicit reason for closing.

Use case is the same: I would like to not be forced to compile 240 tests when including range-v3.

Took the specific syntax / style from the wrap for pegtl.

@neheb
Copy link
Collaborator

neheb commented Feb 5, 2026

Need new entry in releases.json.

@bryceberger
Copy link
Author

CI failure doesn't appear to be my fault.

Went ahead and fixed the formatting / applied suggestions from the script, but I'm unsure what to do about the license field. It seems to have been like that since the wrap was added, and contains (multiple?) non-spdx licenses.

@bryceberger
Copy link
Author

Need new entry in releases.json.

There's one in the first commit.

@neheb
Copy link
Collaborator

neheb commented Feb 5, 2026

isn't the license supposed to be BSL-1.0 ?

@bryceberger
Copy link
Author

bryceberger commented Feb 5, 2026

According to https://github.com/ericniebler/range-v3/blob/ca1388fb9da8e69314dda222dc7b139ca84e092f/LICENSE.txt, it's BSL-1.0 and lic++ and Stepanov and McJones, "Elements of Programming" and SGI STL

The section for libc++ links to the old svn host. Currently, libc++ is licensed under Apache with LLVM exception. Edit: the old libc++ license appears to be NCSA and MIT, according to llvm/llvm-project@469bdef

Unsure about the other two licenses. Neither of them are on the spdx list

@bryceberger bryceberger force-pushed the range-v3/disable-tests branch from 26b59a8 to 595141a Compare February 5, 2026 22:02
@neheb
Copy link
Collaborator

neheb commented Feb 5, 2026

try replacing

,

with

 AND 

@bryceberger
Copy link
Author

Just replacing the commas isn't enough, since the parser (previously) rejected any unknown license text.

I can pull the sanity_checks change into a separate PR if needed, but I believe it (or similar) is required to have this wrap file pass CI.

@bryceberger bryceberger force-pushed the range-v3/disable-tests branch from 277bf09 to af34914 Compare February 5, 2026 23:48
@bryceberger
Copy link
Author

bryceberger commented Feb 5, 2026

Most recent CI failure appears to be ephemeral, but I don't (think that I) have permission to restart it.


======================================================================
ERROR: test_releases (__main__.TestReleases.test_releases) (step='check_new_release', name='range-v3')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/wrapdb/wrapdb/./tools/sanity_checks.py", line 393, in test_releases
    self.check_new_release(name, deps=deps, progs=progs)
  File "/home/runner/work/wrapdb/wrapdb/./tools/sanity_checks.py", line 537, in check_new_release
    res, logs = do_setup(builddir, options, meson_env)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/wrapdb/wrapdb/./tools/sanity_checks.py", line 532, in do_setup
    logs = log_file.read_text(encoding='utf-8')
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/pathlib.py", line 1027, in read_text
    with self.open(mode='r', encoding=encoding, errors=errors) as f:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/pathlib.py", line 1013, in open
    return io.open(self, mode, buffering, encoding, errors, newline)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '_build/meson-logs/meson-log.txt'

Edit: looks like it was my fault, I had range-v3:cpp_std:c++17 in ci_config.json instead of range-v3:cpp_std=c++17

@bryceberger bryceberger force-pushed the range-v3/disable-tests branch 3 times, most recently from e445887 to aadad50 Compare February 9, 2026 17:27
@bryceberger bryceberger force-pushed the range-v3/disable-tests branch 2 times, most recently from 70b760a to 27f4c70 Compare February 9, 2026 22:02
@bryceberger bryceberger force-pushed the range-v3/disable-tests branch from 27f4c70 to f77543d Compare February 10, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants