Conversation
0verLighT
force-pushed
the
xvidcore
branch
26 times, most recently
from
5513e6c to
5109b9d
Compare
|
|
@neheb it should be ok now |
Signed-off-by: 0verLighT <alexandre@0verlight.com>
Signed-off-by: 0verLighT <alexandre@0verlight.com>
0verLighT
force-pushed
the
xvidcore
branch
2 times, most recently
from
b64dad1 to
96b3874
Compare
Signed-off-by: 0verLighT <alexandre@0verlight.com>
| ) | ||
| meson.override_dependency('xvidcore', xvidcore_deps) | ||
|
|
||
| pkg = import('pkgconfig') |
There was a problem hiding this comment.
This belongs above xvidcore_dep I think.
There was a problem hiding this comment.
The last line should be meson.override_dependency() and pkg_config should be above it?
There was a problem hiding this comment.
yeah. pkgconfig relies on the library. override_dependency relies on the dependency.
| include_directories: includes, | ||
| ) | ||
|
|
||
| xvidcore_deps = declare_dependency( |
There was a problem hiding this comment.
_deps should be _dep. This is a single dependency.
| c_args += ['-DHAVE_INTTYPES_H'] | ||
| endif | ||
|
|
||
| if threads_deps.found() and cc.has_header('pthread.h') |
There was a problem hiding this comment.
A bit confusing. thead_dep is not a feature option.
This should be
cc.has_header('pthread.h', dependencies: thread_dep)
In case it's possible or desired to disable threeading.
| sources += files('src/motion/gmc.c') | ||
| endif | ||
|
|
||
| xvidcore = both_libraries( |
There was a problem hiding this comment.
Why is this both_libraries?
There was a problem hiding this comment.
In xvidcore, when you compile it, it generates the static library and the shared library. So i compile both libraries
There was a problem hiding this comment.
It's not needed here. meson supports setting default_library to both which makes library() do the same.
Signed-off-by: 0verLighT <alexandre@0verlight.com>
| ] | ||
|
|
||
| if (cpu_family == 'ppc' or cpu_family == 'ppc64') and endian == 'big' | ||
| sources += [ |
There was a problem hiding this comment.
I don't think [] is needed.
| '-ffast-math', | ||
| '-fomit-frame-pointer', | ||
| '-finline-functions', | ||
| '-fPIC', |
Signed-off-by: 0verLighT <alexandre@0verlight.com>
Signed-off-by: 0verLighT <alexandre@0verlight.com>
Signed-off-by: 0verLighT <alexandre@0verlight.com>
2 participants
Request : #2414