refactor(validation): simplify severity model to blocking vs advisory#753
refactor(validation): simplify severity model to blocking vs advisory#753Junnygram wants to merge 2 commits intomeshery:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the schema validation severity model by consolidating specific classification functions (style, design, and contract) into a single classifyIssue function. It removes the --style-debt and --contract-debt flags, making all non-blocking issues advisory by default. The feedback suggests a minor refinement to the --strict-consistency flag description to better reflect the simplified model.
| // Accept legacy flag aliases — bound to the same variables as their canonical counterparts. | ||
| flag.BoolVar(styleDebt, "legacy-style", false, "Alias for --style-debt") | ||
| flag.BoolVar(contractDebt, "compat-debt", false, "Alias for --contract-debt") | ||
| strict := flag.Bool("strict-consistency", false, "Fail on all advisory and design issues") |
There was a problem hiding this comment.
The flag description mentions "design issues" separately, but under the new model, design issues are now part of the standard advisory set (unless they are hardcoded as blocking). To be more precise and consistent with the simplified model, you might want to update this to simply refer to "advisory issues".
| strict := flag.Bool("strict-consistency", false, "Fail on all advisory and design issues") | |
| strict := flag.Bool("strict-consistency", false, "Fail on all advisory issues") |
There was a problem hiding this comment.
@Junnygram, when feedback offered in any of the agent code review comments has been either incorporated or rejected, please take a moment respond with what change was made to account for the feedback or respond with justification of why the feedback was disregarded.
There was a problem hiding this comment.
@Junnygram, when feedback offered in any of the agent code review comments has been either incorporated or rejected, please take a moment respond with what change was made to account for the feedback or respond with justification of why the feedback was disregarded.
thanks .. will do that
There was a problem hiding this comment.
@Junnygram has this feedback from Gemini been accounted for?
There was a problem hiding this comment.
@Junnygram has this feedback from Gemini been accounted for?
@simihablo , yes it has addressed
Signed-off-by: Junnygram <junnexclusive@gmail.com>
Signed-off-by: Junnygram <junnexclusive@gmail.com>
Junnygram
force-pushed
the
simplify-severity-model
branch
from
a5d0abc to
c4b857c
Compare
3 participants
Closes #728. Collapses 4-tier severity into a standard Blocking/Advisory system.