Replace per-report menu with shared cross-dashboard navigation by Copilot · Pull Request #52 · meshery/qa

Copilot · 2026-04-12T16:37:45Z

Review the new PR comments and inspect the current navigation customization files
Check recent workflow runs/logs for this branch
Remove the unintended website color changes while preserving the shared navigation behavior
Run targeted validation for the updated navigation customization
Run final review/security validation on the committed change
Reply on the new PR comments with the addressing commit and screenshot

Agent-Logs-Url: https://github.com/meshery/qa/sessions/3ade9a24-577c-45dd-a39a-9e1958fd0286 Co-authored-by: pontusringblom <170570911+pontusringblom@users.noreply.github.com>

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Introduces a shared, consistent top navigation across all generated Allure dashboards/reports by injecting navigation metadata into each page and rendering a uniform nav bar while suppressing the legacy per-report menu.

Changes:

Build and inject window.mesheryReportNav into each generated report page during customization.
Render a shared sticky top navigation and mark the active page on load.
Hide the legacy report-specific navigation UI so the shared nav becomes primary.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
customize-report.js	Discovers report pages, computes relative links, and injects shared nav metadata into each page.
custom-script.js	Renders shared nav from injected metadata and hides the legacy menu/panel in the UI.
custom-style.css	Adds styling for the new sticky navigation bar, hover/focus, and active state.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-15T01:47:47Z

+function createNavDataScript(currentPageDir, navEntries) {
+  const navData = navEntries.map(({ label, relativeDir, reportPageDir }) => ({
+    id: relativeDir || 'home',
+    label,
+    href: toRelativeHref(currentPageDir, reportPageDir),
+  }));
+
+  return `    <script>${navDataMarker} ${JSON.stringify(navData)};</script>\n`;
+}


Injecting raw JSON.stringify(navData) into an inline <script> can be broken (and become an XSS/HTML-injection vector) if any string value contains </script> or similar sequences. Consider either (a) emitting the JSON via <script type=\"application/json\" ...> and parsing it in custom-script.js, or (b) escaping < (e.g., replace < with \\u003c) in the serialized JSON before embedding it in HTML.

Copilot · 2026-04-15T01:47:47Z

+function createNavDataScript(currentPageDir, navEntries) {
+  const navData = navEntries.map(({ label, relativeDir, reportPageDir }) => ({
+    id: relativeDir || 'home',


Using relativeDir as an id can produce values containing path separators (e.g., foo/bar) or platform-specific separators if it ever leaks through, which makes the id awkward to consume and inconsistent with the intended stable identifiers. Either sanitize/normalize the id (e.g., slugify and replace separators) or drop id entirely if it’s not used by the client script.

Suggested change

function createNavDataScript(currentPageDir, navEntries) {

const navData = navEntries.map(({ label, relativeDir, reportPageDir }) => ({

id: relativeDir || 'home',

function formatNavId(relativeDir) {

if (!relativeDir) {

return 'home';

}

const normalizedDir = relativeDir.split(path.sep).join('/').replace(/[\\/]+/g, '/');

const sanitizedId = normalizedDir

.split('/')

.filter(Boolean)

.map((segment) => segment.replace(/[^A-Za-z0-9_-]+/g, '-').replace(/^-+|-+$/g, ''))

.filter(Boolean)

.join('-');

return sanitizedId || 'home';

}

function createNavDataScript(currentPageDir, navEntries) {

const navData = navEntries.map(({ label, relativeDir, reportPageDir }) => ({

id: formatNavId(relativeDir),

Copilot · 2026-04-15T01:47:47Z

+  function hideLegacyReportMenu() {
+    let changed = false;
+
+    document.querySelectorAll('button').forEach((button) => {
+      if (button.dataset.mesheryLegacyNavHidden === 'true') {
+        return;
+      }
+
+      if (normalizeText(button.textContent) !== LEGACY_NAV_BUTTON_TEXT) {
+        return;
+      }


Because applyBranding() is typically triggered multiple times (often via a MutationObserver in this kind of customization script), scanning all buttons and panels each time can become expensive on large Allure pages. Consider adding a single page-level guard (e.g., a module-scoped boolean like legacyNavHiddenOnce) and early-return once the legacy menu has been hidden, and/or narrowing the selectors to the known navigation container instead of querying the entire document each time.

@copilot apply changes based on this feedback

Addressed in 0611949.

hideLegacyReportMenu() now uses a module-scoped legacyNavHiddenOnce guard and exits early after the legacy nav has been hidden, so applyBranding() no longer keeps rescanning the full page on later observer runs.

Screenshot:

Copilot · 2026-04-15T01:47:48Z

+.meshery-report-nav__link:hover,
+.meshery-report-nav__link:focus-visible {
+    background: var(--bg-control-secondary-medium, rgba(148, 163, 184, 0.2));
+    border-color: var(--on-border-primary, rgba(100, 116, 139, 0.4));
+    outline: none;


Removing the focus outline on :focus-visible without providing a clearly visible alternative focus indicator can harm keyboard accessibility. Consider replacing outline: none; with an explicit focus ring (e.g., outline or box-shadow) that meets contrast requirements, so focused nav links remain clearly discernible.

Suggested change

.meshery-report-nav__link:hover,

.meshery-report-nav__link:focus-visible {

background: var(--bg-control-secondary-medium, rgba(148, 163, 184, 0.2));

border-color: var(--on-border-primary, rgba(100, 116, 139, 0.4));

outline: none;

.meshery-report-nav__link:hover {

background: var(--bg-control-secondary-medium, rgba(148, 163, 184, 0.2));

border-color: var(--on-border-primary, rgba(100, 116, 139, 0.4));

}

.meshery-report-nav__link:focus-visible {

background: var(--bg-control-secondary-medium, rgba(148, 163, 184, 0.2));

border-color: var(--on-border-primary, rgba(100, 116, 139, 0.4));

outline: 2px solid var(--bg-support-capella, #1d4ed8);

outline-offset: 2px;

winkletinkle · 2026-04-15T03:31:27Z

@copilot apply changes based on the comments in this thread

Agent-Logs-Url: https://github.com/meshery/qa/sessions/65103193-fc41-4af9-99cc-42efc81b6faa Co-authored-by: winkletinkle <182693777+winkletinkle@users.noreply.github.com>

Copilot · 2026-04-15T03:34:45Z

@copilot apply changes based on the comments in this thread

Addressed in 0611949.

Applied the review-thread fixes: escaped the injected nav JSON before embedding it in the inline script, removed the unused nav item id, added a one-time guard around legacy menu hiding, and restored a visible keyboard focus ring for nav links.

Screenshot:

yi-nuo426

@copilot don't change this website's colors.

Agent-Logs-Url: https://github.com/meshery/qa/sessions/88b6f120-ebb7-43e1-9562-33fe68161293 Co-authored-by: yi-nuo426 <218099172+yi-nuo426@users.noreply.github.com>

Copilot · 2026-04-15T22:47:39Z

@copilot apply changes based on the comments in this thread

Addressed in eb9e08e.

The shared nav now keeps the existing site/report palette instead of introducing a new accent-colored active state, while the earlier review-thread fixes remain in place.

Screenshot:

@copilot don't change this website's colors.

Addressed in eb9e08e.

The shared nav no longer changes the website’s colors; the active tab now uses the existing neutral page tones instead of an accent fill.

Screenshot:

Initial plan

a2b19d8

Copilot AI assigned Copilot and pontusringblom Apr 12, 2026

Copilot started work on behalf of pontusringblom April 12, 2026 16:37 View session

Copilot AI linked an issue Apr 12, 2026 that may be closed by this pull request

Replace existing navigation menu #51

Open

Copilot AI and others added 2 commits April 12, 2026 16:47

feat: add shared dashboard navigation

e9e8831

Agent-Logs-Url: https://github.com/meshery/qa/sessions/3ade9a24-577c-45dd-a39a-9e1958fd0286 Co-authored-by: pontusringblom <170570911+pontusringblom@users.noreply.github.com>

chore: polish dashboard navigation injection

a5a4b58

Agent-Logs-Url: https://github.com/meshery/qa/sessions/3ade9a24-577c-45dd-a39a-9e1958fd0286 Co-authored-by: pontusringblom <170570911+pontusringblom@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Replace existing navigation menu with consistent layout~~ Replace per-report menu with shared cross-dashboard navigation Apr 12, 2026

Copilot AI requested a review from pontusringblom April 12, 2026 16:58

Copilot finished work on behalf of pontusringblom April 12, 2026 16:58

leecalcote marked this pull request as ready for review April 15, 2026 01:46

Copilot AI review requested due to automatic review settings April 15, 2026 01:46

Merge branch 'master' into copilot/replace-navigation-menu

c507e3a

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Copilot started work on behalf of winkletinkle April 15, 2026 03:31 View session

fix: address navigation review feedback

0611949

Agent-Logs-Url: https://github.com/meshery/qa/sessions/65103193-fc41-4af9-99cc-42efc81b6faa Co-authored-by: winkletinkle <182693777+winkletinkle@users.noreply.github.com>

Copilot finished work on behalf of winkletinkle April 15, 2026 03:35

Copilot AI requested a review from winkletinkle April 15, 2026 03:35

Copilot started work on behalf of marblom007 April 15, 2026 20:54 View session

Copilot finished work on behalf of marblom007 April 15, 2026 20:56

Copilot AI requested a review from marblom007 April 15, 2026 20:56

yi-nuo426 requested changes Apr 15, 2026

View reviewed changes

Copilot started work on behalf of yi-nuo426 April 15, 2026 22:44 View session

Copilot AI and others added 2 commits April 15, 2026 22:46

fix: keep shared nav within existing site colors

eb9e08e

Agent-Logs-Url: https://github.com/meshery/qa/sessions/88b6f120-ebb7-43e1-9562-33fe68161293 Co-authored-by: yi-nuo426 <218099172+yi-nuo426@users.noreply.github.com>

chore: remove generated report artifact

68928a4

Agent-Logs-Url: https://github.com/meshery/qa/sessions/88b6f120-ebb7-43e1-9562-33fe68161293 Co-authored-by: yi-nuo426 <218099172+yi-nuo426@users.noreply.github.com>

Copilot finished work on behalf of yi-nuo426 April 15, 2026 22:48

Copilot AI requested a review from yi-nuo426 April 15, 2026 22:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace per-report menu with shared cross-dashboard navigation#52

Replace per-report menu with shared cross-dashboard navigation#52
Copilot wants to merge 7 commits intomasterfrom
copilot/replace-navigation-menu

Copilot AI commented Apr 12, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

marblom007 Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

winkletinkle commented Apr 15, 2026

Uh oh!

Copilot AI commented Apr 15, 2026

Uh oh!

yi-nuo426 left a comment

Uh oh!

Copilot AI commented Apr 15, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

-function createNavDataScript(currentPageDir, navEntries) {
-  const navData = navEntries.map(({ label, relativeDir, reportPageDir }) => ({
-    id: relativeDir || 'home',
+function formatNavId(relativeDir) {
+  if (!relativeDir) {
+    return 'home';
+  }
+  const normalizedDir = relativeDir.split(path.sep).join('/').replace(/[\\/]+/g, '/');
+  const sanitizedId = normalizedDir
+    .split('/')
+    .filter(Boolean)
+    .map((segment) => segment.replace(/[^A-Za-z0-9_-]+/g, '-').replace(/^-+|-+$/g, ''))
+    .filter(Boolean)
+    .join('-');
+  return sanitizedId || 'home';
+}
+function createNavDataScript(currentPageDir, navEntries) {
+  const navData = navEntries.map(({ label, relativeDir, reportPageDir }) => ({
+    id: formatNavId(relativeDir),

Conversation

Copilot AI commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

marblom007 Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

winkletinkle commented Apr 15, 2026

Uh oh!

Copilot AI commented Apr 15, 2026

Uh oh!

yi-nuo426 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Copilot AI commented Apr 12, 2026 •

edited

Loading

Copilot AI commented Apr 15, 2026 •

edited

Loading