Skip to content

fix(database): add dbname parameter to postgres dsn #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sm-28601 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(database): add dbname parameter to postgres dsn #970

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
907378e
fix(database): add dbname parameter to postgres dsn
sm-28601 Apr 7, 2026
16e878e
fix(database): conditionally add dbname to postgres DSN
sm-28601 Apr 7, 2026
31cb5af
Merge branch 'master' into fix-dbname-dsn
leecalcote Apr 9, 2026
d187118
Merge branch 'master' into fix-dbname-dsn
leecalcote Apr 9, 2026
166c7ed
Merge branch 'master' into fix-dbname-dsn
sm-28601 Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion database/database.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ type Options struct {
Host string `json:"host,omitempty"`
Port string `json:"port,omitempty"`
Password string `json:"password,omitempty"`
Database string `json:"database,omitempty"`
Filename string `json:"filename,omitempty"`
Engine string `json:"engine,omitempty"`
Logger logger.Handler
Expand Down Expand Up @@ -53,7 +54,14 @@ func New(opts Options) (Handler, error) {
switch opts.Engine {
case POSTGRES:
dsn := fmt.Sprintf("host=%s user=%s password=%s port=%s", opts.Host, opts.Username, opts.Password, opts.Port)
db, err := gorm.Open(postgres.Open(dsn), &gorm.Config{})
if opts.Database != "" {
Copy link
Copy Markdown
Member

@leecalcote leecalcote Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please validate and improve error handling when Database is empty for Postgres.

Is meshery set as the default database name somewhere?

Copy link
Copy Markdown
Author

@sm-28601 sm-28601 Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please validate and improve error handling when Database is empty for Postgres.

Is meshery set as the default database name somewhere?

No, "meshery" is not set as a default database name anywhere. The Postgres path in meshkit is currently unused by Meshery (which uses SQLite) .

dsn = fmt.Sprintf("%s dbname=%s", dsn, opts.Database)
}
config := &gorm.Config{}
if opts.Logger != nil {
config.Logger = opts.Logger.DatabaseLogger()
}
db, err := gorm.Open(postgres.Open(dsn), config)
if err != nil {
return Handler{}, ErrDatabaseOpen(err)
}
Expand Down
Loading