doc: Enhance negotiation tutorial with grid & tools#288
doc: Enhance negotiation tutorial with grid & tools#288
Conversation
for more information, see https://pre-commit.ci
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @colinfrisch , @jackiekazil @wang-boyu |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 300cb8cc77
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| self.memory = STLTMemory( | ||
| agent=self, | ||
| llm_model="ollama/llama3", | ||
| llm_model="ollama/llama3.1:latest ", |
There was a problem hiding this comment.
The Seller tutorial snippet sets llm_model="ollama/llama3.1:latest " (note the trailing space), and ModuleLLM forwards model names as-is, so users who copy this code can end up requesting a non-existent model identifier from Ollama (llama3.1:latest instead of llama3.1:latest). This can cause avoidable model not found failures when running the tutorial.
Useful? React with 👍 / 👎.
2 participants
This PR improves the existing negotiation model tutorial by transforming it from a basic walkthrough into a more structured and insightful guide.
Key enhancements include:
The goal is to make the tutorial more useful for both beginners and advanced users, while keeping it aligned with the existing example implementation.