Fix: Correctly raised value error with descriptive error message in case of Invalid model instead of not a function calling model

[DineshThumma9]

Note

Use this template for bug fixes only. For enhancements/new features, use the feature template and get maintainer approval in an issue/discussion before opening a PR.

Pre-PR Checklist

• This PR is a bug fix, not a new feature or enhancement.

Summary

When given an invalid model name it throws Error with message not a function calling model it might trick user in thinking their model is valid but not function calling and does'nt address actual model invalid issue

Bug / Issue

Fix : #284

Implementation

I added an model validity check right after api key check i used

litellm.get_model_info() 

wrapped in try and except block and raise ValueError when caught an error and show a descriptive message

Testing

Additional Notes

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2fc9b54c-4bbc-40b4-923d-2d47d4f14aae

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.52%. Comparing base (2dfd129) to head (ae4484e).
⚠️ Report is 47 commits behind head on main.

Files with missing lines	Patch %	Lines
mesa_llm/module_llm.py	71.42%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
+ Coverage   91.20%   91.52%   +0.32%     
==========================================
  Files          19       19              
  Lines        1592     1759     +167     
==========================================
+ Hits         1452     1610     +158     
- Misses        140      149       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[wang-boyu]

Thanks for the fix @DineshThumma9 . I think litellm.get_model_info() is too strict to use in __init__, because it also raises for unmapped but valid models such as custom deployments.

I updated the logic so that initialization no longer mislabels invalid models as lacking function-calling support, and invalid-model errors are raised later at completion() time when LiteLLM actually fails to call the model.

Before I merge it, could you please verify that this works for you as expected? Thanks.

[DineshThumma9]

Thanks @wang-boyu! I ran it locally too and it works as expected. No problems on my end. (Also, apologies—I closed this by mistake a moment ago!)

[wang-boyu]

No worries at all, and thanks for the quick confirmation. Merging this now.