Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
please add the tests in the existing test file instead of a new one |
… move test Refactor _build_observation() to handle self.pos is None with a single early return at the top of the vision block, instead of duplicating the guard in each grid/space branch. Move test_generate_obs_with_none_pos from standalone test_agent_observation_none_pos.py into test_llm_agent.py. Delete the standalone file per review feedback.
93b1554 to
292a85e
Compare
for more information, see https://pre-commit.ci
|
thanks for the review, @souro26 . both points addressed. refactored to a single early return at the top and moved tests into |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
==========================================
- Coverage 91.88% 91.83% -0.06%
==========================================
Files 19 19
Lines 1627 1629 +2
==========================================
+ Hits 1495 1496 +1
- Misses 132 133 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the fix. |
Fixes #244