fix(memory): prevent add_to_memory() from overwriting events of the same type#243
fix(memory): prevent add_to_memory() from overwriting events of the same type#243
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
93cb8c4 to
baeb38f
Compare
|
Please add the new tests in existing test files instead of making a new one |
| f"got {content.__class__.__name__}: {content!r}" | ||
| ) | ||
|
|
||
| if type == "observation": |
There was a problem hiding this comment.
observation still stores a dict while other types now store lists. this creates a mixed structure in step_content. It should be unified so all types follow the same format. also, all consumers of step_content now need to handle lists. please keep a single consistent structure to avoid bugs.
a497afa to
7842511
Compare
9908027 to
ee6779c
Compare
for more information, see https://pre-commit.ci
|
thanks for the review. looked into both points. moved tests into existing files and unified all |
Fixes #242Fixes #137