security(kernel): fix buffer overflows in process.c#190
Open
ksaweryr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
kernel/src/process/process.cis riddled with unsafe calls tostrcpythat can potentially lead to buffer overflows. This PR replaces all of them (even the ones that are definitely safe, for consistency) withstrncpywhich protects against that. As an example, the following piece of code triggers a stack buffer overflow insys_execvewhich can be used for arbitrary code execution (the OS crashes with EIP 0xdeadbeef which proves that it's possible to gain control over code execution this way):Related Issues
Changes Made
strcpywith calls tostrncpywith appropriate bounds inkernel/src/process/process.cTASK_NAME_MAX_LENGTHtoNAME_MAXTesting Performed
make qemumake qemu-testChecklist