WIP: Migrate towards ljsonv3#24
Open
gabrielcowley wants to merge 4 commits intomenpo:masterfrom
gabrielcowley:ljsonv3
Open
WIP: Migrate towards ljsonv3#24gabrielcowley wants to merge 4 commits intomenpo:masterfrom gabrielcowley:ljsonv3
gabrielcowley wants to merge 4 commits intomenpo:masterfrom
gabrielcowley:ljsonv3
Conversation
This was referenced Feb 24, 2017
Author
|
Testing has been done against the latest commit on the ljsonv3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue which explains the migration that this PR contributes to can be found here: https://github.com/menpo/landmarker.io/wiki/LEP-0001:-LJSON-v3
This has not been properly tested yet -
landmarkerio-serverdepends on themenpolibrary which has a ljsonv3 migration PR (https://github.com/menpo/menpo/pull/785 ) and this is currently a WIP.