[WC-3245]: Custom Chart conditional visibility#2058
Open
rahmanunver wants to merge 4 commits intomainfrom
Open
[WC-3245]: Custom Chart conditional visibility#2058rahmanunver wants to merge 4 commits intomainfrom
rahmanunver wants to merge 4 commits intomainfrom
Conversation
rahmanunver
force-pushed
the
wc-3245_customcharts_conditional_visibility_bug
branch
2 times, most recently
from
0f16ee4 to
0fc3e52
Compare
rahmanunver
force-pushed
the
wc-3245_customcharts_conditional_visibility_bug
branch
from
0fc3e52 to
4cd9e10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Due to conditional visibility preventing rendering multiple times on data change (usually dataLength=0 -> dataLength=2 - and so on, with conditional visibility this doesn't happen), the custom chart is preserving the stale data.
This fix introduces a new resetData usage and trigger update on EditorStore with the fresh data.
What should be covered while testing?
Check if custom charts with conditional visibility are refreshing data as excpected also playground.
Other charts also should work as expected as these changes involve shared store state code.