Allow use of DBT_PROJECT_DIR env var as per help text and dbt cli#82
Open
anentropic wants to merge 2 commits intomemiiso:mainfrom
Open
Allow use of DBT_PROJECT_DIR env var as per help text and dbt cli#82anentropic wants to merge 2 commits intomemiiso:mainfrom
anentropic wants to merge 2 commits intomemiiso:mainfrom
Conversation
Contributor
Author
|
I think the errors in the dbt output in the tests are expected cases? so the failing test here is: ...i.e. something in testcontainers failing at import time? |
| envvar="DBT_PROFILES_DIR", | ||
| help="Path to the dbt profiles directory. Defaults to the DBT_PROFILES_DIR environment variable.", | ||
| ) | ||
| ns, args = parser.parse_known_args() |
Member
There was a problem hiding this comment.
Thank you @anentropic adding it, would it be simpler to add if else block instead? what do you think?
if ns.project_dir:
project_dir = Path(ns.project_dir)
elif os.getenv("DBT_PROJECT_DIR"):
project_dir = Path(os.getenv("DBT_PROJECT_DIR"))
else:
project_dir = default_project_dir()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to make
DBT_PROJECT_DIRandDBT_PROFILES_DIRenv vars work as cli defaults.dbt cli allows this, and the help text in opendbt cli args say you can but it doesn't work.
The reason is it currently just takes the argparse result (
None) and falls back toelse default_project_dir()...but the dbtdefault_project_dirfunction doesn't do the env var handling.Instead that is a feature of the
clickinterface:https://github.com/dbt-labs/dbt-core/blob/main/core/dbt/cli/params.py#L476
So for dbt cli the default function is only called if no env var defined.
We can reproduce the same behaviour in argparse with some helper code adapted from:
https://stackoverflow.com/a/10551190/202168