Skip to content

Fix for "Invalid child context type 'virtualizedCell.cellKey'"#69

Open
schmoove wants to merge 1 commit into
meliorence:masterfrom
schmoove:master
Open

Fix for "Invalid child context type 'virtualizedCell.cellKey'"#69
schmoove wants to merge 1 commit into
meliorence:masterfrom
schmoove:master

Conversation

@schmoove

Copy link
Copy Markdown

No description provided.

@slorber

slorber commented Apr 19, 2018

Copy link
Copy Markdown

this PR seems fine, small and safe. Can it be merged and released?

@geastwood

Copy link
Copy Markdown

This PR fix the warning, can we merge this please?

@tavriaforever

Copy link
Copy Markdown

@Exilz Hi! Could you merge this PR?

@mahdikhosravi mahdikhosravi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK! Please accept it

@fzyzcjy

fzyzcjy commented Jul 12, 2018

Copy link
Copy Markdown

+1

@schmoove

schmoove commented Aug 4, 2018

Copy link
Copy Markdown
Author

Could an admin merge this please - I just reinstalled the lib and was surprised to get the same error after all this time! Thx :)

@AndrewSouthpaw

Copy link
Copy Markdown

@konkissner

Copy link
Copy Markdown

+1

@alexandrecanuto

Copy link
Copy Markdown

If anyone's interested, I've forked this repo fixing this and adding a maxScale option. https://github.com/ever-digital/react-native-image-gallery

@shiftrtech

shiftrtech commented Oct 20, 2018

Copy link
Copy Markdown

If anyone's interested, I've forked this repo fixing this and adding a maxScale option. https://github.com/ever-digital/react-native-image-gallery

yarn remove react-native-image-gallery

yarn add https://github.com/ever-digital/react-native-image-gallery.git#master

@alexandrecanuto thanks.

@jstarw

jstarw commented Mar 9, 2019

Copy link
Copy Markdown

Can this be merged please? It's been over a year

@sungsong88

Copy link
Copy Markdown

Please! Please merge this! 🙏

@migueldaipre

Copy link
Copy Markdown

Please merge this!

@peckpeck20

Copy link
Copy Markdown

@Exilz @bd-arc if its safe to merge, please do :)

@dimgrav

dimgrav commented Jul 23, 2019

Copy link
Copy Markdown

Why is this still not merged!?

@geirman

geirman commented Jul 23, 2019

Copy link
Copy Markdown

@dimgrav probably because the Archriss has more profitable or more interesting things to do with his limited time? This repo hasn't been active for a while. Maybe you can volunteer to take it over? Or fork it and start maintaining your own fork. The beauty of OSS is you always have options.

@dimgrav

dimgrav commented Jul 23, 2019

Copy link
Copy Markdown

@geirman I was actually ready to make a PR to the Mattermost fork, but saw that this is pending, so I thought I'd give it a shout.

@NTKrieger

NTKrieger commented May 27, 2021

Copy link
Copy Markdown

yarn remove react-native-image-gallery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.