Support JSString in ChoiceString when compiling with ghcjs#32
Open
waern wants to merge 1 commit intomeiersi:task-rename-and-cleanupfrom
Open
Support JSString in ChoiceString when compiling with ghcjs#32waern wants to merge 1 commit intomeiersi:task-rename-and-cleanupfrom
waern wants to merge 1 commit intomeiersi:task-rename-and-cleanupfrom
Conversation
Collaborator
|
Thanks for the PR. I wonder whether there wouldn't be the possibility for a version of the |
Collaborator
|
And you'd use backpack to swap out the different implementations? |
Collaborator
|
Hmm..interesting. I was thinking about conditionals in the cabal file, which would probably be placed in a |
Collaborator
|
Oh yes, that also sounds like it would work (and has the benefit of using technology which exists). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids costly conversions if you're writing an SPA and have JSStrings in your state.