feat: Request retry for 429 and 503 responses with exponential backoff#28
Open
andrespd99 wants to merge 2 commits into
Open
feat: Request retry for 429 and 503 responses with exponential backoff#28andrespd99 wants to merge 2 commits into
andrespd99 wants to merge 2 commits into
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 79.59% 76.22% -3.38%
==========================================
Files 9 9
Lines 446 408 -38
==========================================
- Hits 355 311 -44
- Misses 68 70 +2
- Partials 23 27 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds automatic request retry with backoff for retryable responses (429 and 503) and customizable parameters.
Changes
Rewrote Client.do to:
Client.maxRetriestimes on HTTP 429 and 503 with exponential backoff and jitter.makeHTTPClientErrorcan read it.Notes and rationale
makeHTTPClientErrorimmediately.req.GetBodyso each attempt can get a fresh Body reader. This matches howhttpexpects retryable requests to behave.makeHTTPClientErrorcan read the body (it callsio.ReadAll).