Fix invariants that used the 'conformsTo' function which isn't supported by various SDK's #57
Merged
Conversation
Linting Result: ❌Linting found the following potential problems/warnings |
QA Report status
|
Contributor
|
A clarifying question: why change this so that there only needs to be a MessageHeader? |
tmsMedcom
reviewed
Feb 9, 2026
Contributor
Author
It has been removed entirely now, the reason I'm doing this is because we cannot use the 'conformsTo' function due to the SDK constraints, so there really isn't anything to do other than making invariants in the dependent IG's that asserts that the messageHeader is of a certain type |
sksMedcom
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the medom-messaging-1 invariant. I'm doing this because we cannot use the 'conformsTo' function due to the SDK constraints. Dependent IG's such as CareCommunication will then asserts that the messageHeader is of a certain type