refactor(platform): move distro detection and package fetching (#10) #21
+24
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baync180705
reviewed
Dec 17, 2025
Collaborator
baync180705
left a comment
baync180705
left a comment
There was a problem hiding this comment.
Have added some reviews, kindly fix them, won't take much time
| import ( | ||
| "fmt" | ||
| "time" | ||
| ) |
Collaborator
There was a problem hiding this comment.
Simply remove these comments
Collaborator
There was a problem hiding this comment.
This Binary is not supposed to be added. Remove this and update the .gitignore if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Moves distro detection and package fetching logic into a dedicated platform layer for better structure and clarity.
Changes
internal/platformdirectoryutilstoplatformVerification
go run main.goworks as expectedCloses #10