Fix a syntax error and add module support#5
Open
dnephin wants to merge 2 commits into
Open
Conversation
And also add go.mod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for writing this tool! I had starred it a while ago, and finally had a chance to try it out.
When I tried to install it, I first ran into a syntax error. Then I ran into trouble because the tool was still using the old x/tools interfaces that do not support modules.
This PR fixes the syntax error (first commit), and adds go module support and its own
go.modfile.I see you haven't committed to this repo in a while, but I thought I'd share these changes in case you were interested. I added a bunch of extra validation while debugging some problems, which maybe isn't all entirely necessary.