Fix tokenizer problem with commas inside NMR peaks#18
Open
0x33467 wants to merge 17 commits intomcs07:masterfrom
Open
Fix tokenizer problem with commas inside NMR peaks#180x33467 wants to merge 17 commits intomcs07:masterfrom
0x33467 wants to merge 17 commits intomcs07:masterfrom
Conversation
Owner
|
Sorry I've taken so long to review this - there's some great stuff here. But could you create separate branches for each individual change so they can have separate, more focused Pull Requests? That way you can also continue developing on your Some help documentation here: |
Author
|
Ok, I'll do that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I found a problem while you are reading NMR peaks when you have no whitespace between two elements, like this:
9.73 (s,1H)
This is parsed as a peak with an assignment instead of a peak with a multiplicity and a number, I also add some cases for other contexts when you have some coupling units.