Count all warnings in mcs doctor summary#352
Merged
Merged
Conversation
- Inject a shared WarningCounter into CLIOutput so advisories emitted outside the check loop (collision renames, unregistered packs) are tallied - Return DoctorSummary from DoctorRunner.run() and add regression tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcs doctorprints a warning when a pack artifact collides with a pre-existing file it doesn't manage (e.g. a skill whose name matches an existing unmanaged skill), but the summary line always reported0 warningsfor it. Only warnings raised by health checks were counted; advisories emitted around the check loop printed but were never tallied. The summary now reflects every warning the user actually saw.Changes
--packid, and unreadable-state advisories.Test plan
swift testpasses locallyswiftformat --lint .andswiftlintpass without violations.claude/skills/<name>, runmcs doctor→ the collision warning is reflected in the summary's warning count (previously0)Checklist for engine changes
DoctorRunnerIntegrationTests)