Skip to content

update rems admin to work with auth number to case number migration#173

Closed
smalho01 wants to merge 8 commits into
devfrom
authNumber->caseNumber
Closed

update rems admin to work with auth number to case number migration#173
smalho01 wants to merge 8 commits into
devfrom
authNumber->caseNumber

Conversation

@smalho01

@smalho01 smalho01 commented Jun 13, 2025

Copy link
Copy Markdown
Collaborator

Describe your changes

migrate from auth number to case number instead

Issue ticket number and Jira link

https://jira.mitre.org/browse/REMS-828

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@@ -29,6 +29,7 @@ export class GuidanceResponseUtilities {
RemsCase,
| 'drugName'
| 'auth_number'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we leave auth_number in if it is being replaced with the case_number?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we want to get rid of it completely? I simply removed references to auth_number in other systems but still have it being set in the rems admin in case we ever need to do something with it in the future as a sort of internal authorization number. If we want I can remove all references to auth entirely

@smalho01 smalho01 closed this Jun 13, 2025
@smalho01 smalho01 deleted the authNumber->caseNumber branch June 13, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants