Skip to content

Removed call to deprecated SplitterWindow.SetSashSize(). Fixes issue #3#4

Open
s4v4g3 wants to merge 1 commit intomcfletch:masterfrom
s4v4g3:master
Open

Removed call to deprecated SplitterWindow.SetSashSize(). Fixes issue #3#4
s4v4g3 wants to merge 1 commit intomcfletch:masterfrom
s4v4g3:master

Conversation

@s4v4g3
Copy link
Copy Markdown

@s4v4g3 s4v4g3 commented May 19, 2020

Fix for issue reported in #3

@bfung
Copy link
Copy Markdown

bfung commented Jun 17, 2020

I had the same error as described in #3 . I installed this patch on my local machine:

$ pip install git+https://github.com/s4v4g3/runsnakerun.git@836bea078685e3de468027228497d1ad8d94916b

And executing runsnake now works as expected!
Screen Shot 2020-06-17 at 3 34 16 PM

@nima
Copy link
Copy Markdown

nima commented Feb 10, 2021

This doesn't work for me.

/Users/nimbler/rh/.venv/lib/python3.9/site-packages/runsnakerun/listviews.py:265: wxPyDeprecationWarning: Using deprecated class. Use ItemAttr instead
  indicated_attribute = wx.ListItemAttr()
2021-02-10 11:56:55.511 Python[14680:144802] ApplePersistenceIgnoreState: Existing state will not be touched. New state will be written to (null)
11:56:55 AM: Debug: Adding duplicate image handler for 'PNG file'
Traceback (most recent call last):
  File "/Users/nimbler/rh/.venv/lib/python3.9/site-packages/runsnakerun/runsnake.py", line 836, in OnInit
    frame = MainFrame(config_parser=load_config())
  File "/Users/nimbler/rh/.venv/lib/python3.9/site-packages/runsnakerun/runsnake.py", line 216, in __init__
    self.CreateControls(config_parser)
  File "/Users/nimbler/rh/.venv/lib/python3.9/site-packages/runsnakerun/runsnake.py", line 268, in CreateControls
    self.rightSplitter.SetSashSize(10)
AttributeError: 'SplitterWindow' object has no attribute 'SetSashSize'
OnInit returned false, exiting...

@iFreilicht
Copy link
Copy Markdown

@nima Uninstall runsnakerun first:

pip uninstall runsnakerun

And THEN install the version from @s4v4g3's fork:

pip install git+https://github.com/s4v4g3/runsnakerun.git@836bea078685e3de468027228497d1ad8d94916b

@mcfletch I tested this as well and it works perfectly! Would be great if you could merge and release this change :)

@iFreilicht
Copy link
Copy Markdown

Ah but I just saw that this makes all the table columns very small by default, which is quite annoying. Somehow, the size should be set in a different way.

@mkaniaa
Copy link
Copy Markdown

mkaniaa commented May 17, 2022

@nima Uninstall runsnakerun first:

pip uninstall runsnakerun

And THEN install the version from @s4v4g3's fork:

pip install git+https://github.com/s4v4g3/runsnakerun.git@836bea078685e3de468027228497d1ad8d94916b

@mcfletch I tested this as well and it works perfectly! Would be great if you could merge and release this change :)

It worked perfectly for me. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants