store path in self.path (currently it's always None)#3
Open
davidc wants to merge 3 commits intomcb30:masterfrom
Open
store path in self.path (currently it's always None)#3davidc wants to merge 3 commits intomcb30:masterfrom
davidc wants to merge 3 commits intomcb30:masterfrom
Conversation
mcb30
requested changes
Jan 26, 2023
Owner
mcb30
left a comment
mcb30
left a comment
There was a problem hiding this comment.
This goes against the idea that path is an optional InitVar that the caller may use to initialise file. There is nothing within HmrcTokenFileStorage that requires a file with an associated path: only a file-like object is needed.
At a minimum, the patch would have to also remove the InitVar declaration.
What is the motivation for having an HmrcTokenFileStorage object expose the path to the token?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.