Skip to content

Fix bad propType warnings #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacopotarantino wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix bad propType warnings #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a325922
Fix broken lint rules
jacopotarantino Apr 10, 2019
40f9ea4
Shape up test suite
jacopotarantino Apr 10, 2019
726d8a9
Fix last lint error
jacopotarantino Apr 10, 2019
44b2981
Fix prop-types warning
jacopotarantino Apr 10, 2019
30eea5d
Run build before publish
jacopotarantino Apr 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .prettierrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"trailingComma": "es5",
"tabWidth": 2,
"semi": true,
"singleQuote": true,
"arrowParens": "always"
}
Copy link
Owner

@mcarlucci mcarlucci May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file an oversight? I don't see any packages installed or npm scripts that would leverage this file. I'm certainly not opposed to adding it, although eslint already supports prettier formatting that can be installed using the ESLint ecosystem. See https://prettier.io/docs/en/integrating-with-linters.html

15 changes: 6 additions & 9 deletions __tests__/ReactPreCacheImg-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,14 @@
jest.unmock('../src/ReactPreCacheImg');
jest.unmock('../src/react-precache-img');

import React from 'react';
import ReactDOM from 'react-dom';
import TestUtils from 'react-addons-test-utils';
import ReactPreCacheImg from '../src/ReactPreCacheImg'
import renderer from 'react-test-renderer';
import ReactPreCacheImg from '../src/react-precache-img';

describe('<ReactPreCacheImg />', () => {
it('', () => {
const renderer = TestUtils.createRenderer();
renderer.render(
<ReactPreCacheImg />
const component = renderer.create(
<ReactPreCacheImg images={['foo.jpg', 'bar.jpg']} />
);
const dom = renderer.getRenderOutput();
//expect(dom.props.//PROPS_NAME).toEqual('//TEXT');
expect(component.props.images.length).toBe(2);
});
});
19 changes: 7 additions & 12 deletions __tests__/ReactPreCacheImgDemo-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
jest.unmock('../src/ReactPreCacheImgDemo');
jest.unmock('../src/PreCacheImgDemo');

import React from 'react';
import ReactDOM from 'react-dom';
import TestUtils from 'react-addons-test-utils';
import ReactPreCacheImgDemo from '../src/ReactPreCacheImgDemo.jsx'
import renderer from 'react-test-renderer';
Copy link
Owner

@mcarlucci mcarlucci May 9, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting the following failures when running npm run test:

| ~/projects/react-precache-img @ MacBook-Pro (mcarlucci) 
| => npm run test

> react-precache-img@2.0.6 test /Users/mcarlucci/projects/react-precache-img
> BABEL_JEST_STAGE=0 jest

 PASS  __tests__/index-test.js
 FAIL  __tests__/ReactPreCacheImg-test.js
  ● Test suite failed to run

    TypeError: Cannot read property 'hasOwnProperty' of undefined
      
      at node_modules/react-test-renderer/cjs/react-test-renderer.development.js:151:27
      at Object.<anonymous> (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13241:5)
      at Object.<anonymous> (node_modules/react-test-renderer/index.js:6:20)
      at Object.<anonymous> (__tests__/ReactPreCacheImg-test.js:4:52)
      at process._tickCallback (internal/process/next_tick.js:68:7)

 FAIL  __tests__/ReactPreCacheImgDemo-test.js
  ● Test suite failed to run

    TypeError: Cannot read property 'hasOwnProperty' of undefined
      
      at node_modules/react-test-renderer/cjs/react-test-renderer.development.js:151:27
      at Object.<anonymous> (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13241:5)
      at Object.<anonymous> (node_modules/react-test-renderer/index.js:6:20)
      at Object.<anonymous> (__tests__/ReactPreCacheImgDemo-test.js:4:52)
      at process._tickCallback (internal/process/next_tick.js:68:7)

Test Suites: 2 failed, 1 passed, 3 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        1.071s
Ran all test suites.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! react-precache-img@2.0.6 test: `BABEL_JEST_STAGE=0 jest`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the react-precache-img@2.0.6 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/mcarlucci/.npm/_logs/2019-05-09T05_40_55_956Z-debug.log

import PreCacheImgDemo from '../src/PreCacheImgDemo';

describe('<ReactPreCacheImgDemo />', () => {
it('', () => {
const renderer = TestUtils.createRenderer();
renderer.render(
<ReactPreCacheImgDemo />
);
const dom = renderer.getRenderOutput();
//expect(dom.props.//PROPS_NAME).toEqual('//TEXT');
describe('<PreCacheImgDemo />', () => {
it('should render', () => {
const component = renderer.create(<PreCacheImgDemo />);
expect(component).toBeDefined();
});
});
16 changes: 4 additions & 12 deletions __tests__/index-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,9 @@
jest.unmock('../src/index');

import React from 'react';
import ReactDOM from 'react-dom';
import TestUtils from 'react-addons-test-utils';
import index from '../src/index'
import index from '../src/index';

describe('<index />', () => {
it('', () => {
const renderer = TestUtils.createRenderer();
renderer.render(
<index />
);
const dom = renderer.getRenderOutput();
//expect(dom.props.//PROPS_NAME).toEqual('//TEXT');
describe('index', () => {
it('references all components', () => {
expect(typeof index).toBe('function');
});
});
10 changes: 5 additions & 5 deletions demo/PreCacheImgDemo.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading