Skip to content

fix(bus): deduplicate added trips#699

Merged
runkelcorey merged 4 commits intomainfrom
fix-bus-stop-sequence
Feb 4, 2026
Merged

fix(bus): deduplicate added trips#699
runkelcorey merged 4 commits intomainfrom
fix-bus-stop-sequence

Conversation

@runkelcorey
Copy link
Collaborator

Asana Task

What changes does this PR propose?

Adds TM's pullout ID and vehicle label as primary keys to deduplicate added/overloaded trips.

How were these changes validated?

  1. Updates existing tests
  2. Adds new test to ensure that TM stop sequence is monotonic
  3. Ran many examples

What questions should reviewers consider?

None.

@runkelcorey runkelcorey requested a review from a team as a code owner February 3, 2026 20:18
@runkelcorey runkelcorey requested a review from huangh February 3, 2026 20:18
@runkelcorey runkelcorey self-assigned this Feb 3, 2026
@runkelcorey runkelcorey added bug Something isn't working bus_performance labels Feb 3, 2026
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

LCOV of commit 50e3b83 during Continuous Integration (Python) #1731

Summary coverage rate:
  lines......: 61.5% (3300 of 5364 lines)
  functions..: 28.3% (255 of 900 functions)
  branches...: no data found

Files changed coverage rate:
                                                                                     |Lines       |Functions  |Branches    
  Filename                                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================================
  src/lamp_py/bus_performance_manager/combined_bus_schedule.py                       |97.1%     35|50.0%     2|    -      0
  src/lamp_py/bus_performance_manager/events_joined.py                               |77.4%     62|31.2%    16|    -      0
  src/lamp_py/bus_performance_manager/events_metrics.py                              |67.2%     58|33.3%    12|    -      0
  src/lamp_py/bus_performance_manager/events_tm.py                                   |69.6%     56|33.3%     6|    -      0
  src/lamp_py/bus_performance_manager/events_tm_schedule.py                          | 100%     32|50.0%     2|    -      0
  src/lamp_py/tableau/jobs/bus_performance.py                                        |55.9%     59| 0.0%    18|    -      0

@runkelcorey runkelcorey merged commit 1b7ff44 into main Feb 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working bus_performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant