fix(UpcomingDepartures): Show cancelled bus trips#2928
Open
joshlarson wants to merge 1 commit intomainfrom
Open
fix(UpcomingDepartures): Show cancelled bus trips#2928joshlarson wants to merge 1 commit intomainfrom
joshlarson wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: [SF/UD] Show cancelled bus trips
Implementation
arrival_status/1so that it gives cancelled bus trips a status of{:cancelled, time}, rather than omitting them.Screenshots
How to test
Create a bus cancellation alert (this can only be done in IBI Alerts UI). Make sure you cancel a trip whose visit to the stop you're looking at is in the future.