(fix) Update local dev dockerfile to include npm dependency#2927
Open
(fix) Update local dev dockerfile to include npm dependency#2927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
While attempting to set up my dotcom work environment, various errors related to redis prevented things from working as the readme describes. A different docker-based solution to running dotcom is present (/deploy/dotcom/dev/dockerfile), but was failing to install npm and therefore couldn't run dotcom.
Implementation
Updated dev dockerfile to install npm as well as nodejs from apt. The build was failing due to the lack of npm, adding it to the apt-get line seems to have worked
Screenshots
How to test
After freshly cloning the repo, run
docker compose -f deploy/dev.yml up -d --build