fix(UpcomingDepartures): omit past skip/canceled#2925
Merged
thecristen merged 1 commit intomainfrom Feb 6, 2026
Merged
Conversation
joshlarson
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: [SF/UD] Don't show past cancelled trips as upcoming departures
Implementation
Added a clause to the logic filtering out past schedules to treat skipped/cancelled predictions the same as we currently treat a
nilprediction.Screenshot
2:18PM
after 2:21PM
How to test
Issue a test alert which cancels a bus or commuter rail trip, and watch it disappear from Upcoming Departures at the requisite time.