fix: Don't show trip-specific alerts on the line diagram#2922
Merged
joshlarson merged 3 commits intomainfrom Feb 3, 2026
Merged
fix: Don't show trip-specific alerts on the line diagram#2922joshlarson merged 3 commits intomainfrom
joshlarson merged 3 commits intomainfrom
Conversation
joshlarson
force-pushed
the
jdl/fix/dont-show-train-specific-alerts-on-line-diagram
branch
from
9f5c6bd to
8887127
Compare
joshlarson
deleted the
jdl/fix/dont-show-train-specific-alerts-on-line-diagram
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: ❗[AM Alerts] Don't show train(s) specific alerts on line diagram
Implementation
Screenshots
(for context, the
Wellesley Farmsalert applied only to a few trips, while theAuburndaleone applied to the whole day - see screenshot 👇)How to test
Create a station closure or station bypass test alert for a commuter rail route, and have it apply to some specific trips (rather than all trips). Examine the line diagram, and note that the stations you closed don't show as
Skipped.Create a station closure or station bypass test alert for a commuter rail route, and have it apply to all trips. Examine the line diagram, and note that the stations you closed do appear as
Skipped.