fixup: Trip planner itinerary tagging

[thecristen]

Summary of changes

Asana Ticket: Trip planner itinerary tagging: implement tie-breaking & new "most direct" tag (tie-breaking with fallback)

Sorry, there's not much here! Most of the actual implementation of the new tag, as well as implementation of tagging in general, is in thecristen/open_trip_planner_client@v0.5.0...v0.6.1 in the OpenTripPlannerClient.ItineraryTag and OpenTripPlannerClient.ItineraryTag.MostDirect modules.

[thecristen]

This shouldn't be put live until mbta/otp-deploy#35 is merged. However, I'll open this PR to review with a deployment to Dotcom dev-blue once I finish deploying OTP with the needed changes to OTP dev-blue.

[kotva006]

These seem to be added as dependencies but not used in this pull request

[thecristen]

The commit message that added these was fixup merge commit....these were supposed to be in the feat/trip-planner-improvements branch (and are being used there already).

[kotva006]

Is the goal of the open_trip_planner_client to replace the implementation of the open_trip_planner.ex?
I am confused because they both seem to still exist and be doing similar things

[thecristen]

@kotva006 Yeah, just the plan/3 function specifically. See the description of a previous PR to this branch for more: #1883

[kotva006]

@kotva006 Yeah, just the plan/3 function specifically. See the description of a previous PR to this branch for more: #1883

I am not tracking. If the open_trip_planner_client library replaces the plan/3 function, why does the function still exist?

[thecristen]

@kotva006 Did you see the source? https://github.com/mbta/dotcom/blob/cbj/fix-tags/lib/trip_plan/api/open_trip_planner.ex#L18

Our plan/3 function calls the function returned by Application.get_env(:dotcom, :trip_planner, OpenTripPlannerClient). In prod/dev that just refers to the OpenTripPlannerClient.plan/3 function, but in MIX_ENV=test it's configured to point to a different function that's used for testing.