(fix): initialize googleClient OAuth2Client instance before use#109
Open
Siddh2024 wants to merge 1 commit into
Open
(fix): initialize googleClient OAuth2Client instance before use#109Siddh2024 wants to merge 1 commit into
Siddh2024 wants to merge 1 commit into
Conversation
- googleClient was imported but never instantiated, causing ReferenceError - Added conditional initialization with GOOGLE_CLIENT_ID env var - Added guard to return 503 if Google auth is not configured
Contributor
|
@Siddh2024 is attempting to deploy a commit to the Mayo's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
googleClientwas imported but never instantiated (new OAuth2Client(...)), so any Google OAuth request would throw aReferenceErrorat runtime. This fix initializes the client whenGOOGLE_CLIENT_IDis configured and adds a guard to return a clear error when it's not configured.Changes
googleClientOAuth2Client instance after JWT_SECRET checkDetails
The existing frontend flow (Google GSI SDK in
login.html/signup.html, token exchange inauth.js) was already correctly implemented — only the backend initialization was missing.closes #70 , @mayo-byte07 , please approve this PR , thnx.